-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Cargo audit infrastructure #1359
Conversation
Trust set imported from `zcash/zcash` where there were common deps.
As with our `cargo-vet` usage in `zcash/zcash`, these are binary crates for interacting with Windows APIs, so both sides are maintained by Microsoft and are not something we can audit ourselves.
Most of the config is copied from `zcash/zcash`, but with a few extra license exceptions due to the `download-params` feature of `zcash_proofs` and the `lightwalletd-tonic-transport` feature of `zcash_client_backend`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I did not carefully review the audit claims from other organizations.
The other orgs are all ones we already depend on for audits in |
version = "0.2.88" | ||
criteria = "safe-to-deploy" | ||
|
||
[[exemptions.wasm-bindgen-macro-support]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK
This starts the process of removing our dependency on
zcash/zcash
for ourcargo-vet
audits. We import audits from there and other upstreams to bootstrap audits here; once this PR merges, we'll include this repo into our aggregated audit set, and then we can use audits here (for the MSRV-compatible dependencies pinned in this repo'sCargo.lock
) to augment the audits done in our end binary repos (zcashd
and the mobile SDKs, which use as close to stable Rust as we can).